Various version statement fixes #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where users somehow get hold of versions of rustup which are not cleanly built by CI, we need a way to find out what the dirtiness was caused by. This will let us do it either by: $ rustup-init --dump-testament or, once installed, $ rustup dump-testament Signed-off-by: Daniel Silverstone <[email protected]>
We were leaving a `rustup-init.exe` behind which dirtied the git repository, meaning that the version number was unpleasant for Windows users. This fixes that. Signed-off-by: Daniel Silverstone <[email protected]>
To allow us to ensure that we do not have unexpected version strings due to dirty builds etc, dump the testament after the build but before running the tests. We can't do this for unusual cross-builds but for the most part we can do it on at least one of each of our major platforms. Signed-off-by: Daniel Silverstone <[email protected]>
Once we've made the builds on stable, add a double-check step to ensure that the version numbers reported by the various built versions of `rustup-init` actually are the correct versions as expected for the build. Dirty git repos, missed updates, etc will show here. Signed-off-by: Daniel Silverstone <[email protected]>
tesuji
approved these changes
May 1, 2019
|
Thanks for the review @lzutao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rolls up an addition of a hidden flag/command to dump the version testament which can be used if in the future a user receives an unexpectedly unclean version of rustup-init.
We use that in the CI pipeline to dump the version which would be displayed so that we can check it during our stable release process.
Also this includes a commit to remove a dirtying step (or rather to clean up after it) in our appveyor builds.