few corrections for guess_os_stack_limit() on OpenBSD #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- assert_eq!() syntax - `ss_sp` is pointer (not usize) - `ss_sp` is top (well, for all archs except hppa on OpenBSD, but hppa isn't supported by rust for now)
|
technically, it isn't enough to make stacker to work on OpenBSD. in particular, |
use mmap(2) instead of mprotect(2) to pass MAP_STACK
|
now, it is enough for openbsd (with #33) |
Is this a strict requirement on OpenBSD? Do you know why? Some other platforms also have a EDIT: Ah, I see the comment on the issue. |
|
(Merged as 93325b4) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2020
…acrum update stacker to 0.1.9 to unbreak build on OpenBSD the version 0.1.8 of stacker (what is currently pinned in Cargo.lock) doesn't build on OpenBSD (see rust-lang/stacker#34). update the version to 0.1.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ss_spis pointer (not usize)ss_spis top (well, for all archs except hppa on OpenBSD, but hppa isn't supported by rust for now)