Fix unused link_name attribute. #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
|
@Amanieu Is it OK for me to bump the stdarch module on rust-lang/rust? |
|
Yes, that's fine. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 20, 2021
Update stdarch 5 commits in 815d55c..cfba59f 2021-11-08 00:58:47 +0000 to 2021-11-19 01:29:04 +0000 - Work-around buggy Intel chips erroneously reporting BMI1/BMI2 support (rust-lang/stdarch#1249) - complete armv8 instructions (rust-lang/stdarch#1256) - Fix i8mm feature with bootstrap compiler. (rust-lang/stdarch#1252) - Fix unused link_name attribute. (rust-lang/stdarch#1251) - Add remaining insturctions (rust-lang/stdarch#1250)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there was a mistake commenting out this function, which left an unused attribute.
Unblocks rust-lang/rust#88681 which is extending the unused_attributes lint to catch more situations.