Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MIPS from CI #1448

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Remove MIPS from CI #1448

merged 2 commits into from
Jul 29, 2023

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Jul 29, 2023

These targets have been removed from rustup, see rust-lang/compiler-team#648.
@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2023

@Amanieu: no appropriate reviewer found, use r? to override

@Amanieu
Copy link
Member Author

Amanieu commented Jul 29, 2023

@alexcrichton It seems that there has been some breakage to WASM in stdarch. Specifically, the problem is that functions like i8x16 are defined as const fn but also have a #[target_feature(enable = "simd128")], which now causes them to fail in const-eval. I've removed the target feature attribute from all const fn, since those should never require the target feature anyways.

@Amanieu Amanieu merged commit c5b0076 into rust-lang:master Jul 29, 2023
@Amanieu Amanieu deleted the remove-mips branch July 29, 2023 21:38
@alexcrichton
Copy link
Member

Apologies for the delayed response but that sounds good to me! Given that these are all constant-creating things they don't need the feature anyway to work with LLVM's codegen so all seems reasonable to me. Thanks for taking care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants