Explain the discrepancy in the mask type for _mm_shuffle_ps #879
Conversation
…Rust and Intel's Intrinsics Guide
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
georgio
changed the title
crates/core_arch/src/x86/sse.rs
Outdated
| /// `_mm_shuffle_ps` is supposed to take an `i32` instead of an `u32` | ||
| /// as is the case for [other shuffle intrinsics](https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_shuffle_). | ||
| /// Performing an implicit type conversion between an unsigned integer and a signed integer | ||
| /// does not cause a problem in C, however Rust's commitment to safety does not allow this. |
There was a problem hiding this comment.
suggestion:
however Rust's commitment to strong typing does not allow this.
u32/i32 flipping isn't a safety related issue, at least not in this case.
There was a problem hiding this comment.
That's correct, it's more an issue of Rust's strong typing vs C's weak typing which allows much more implicit conversions.
There was a problem hiding this comment.
Thank you for your suggestion! It has been added.
|
Thanks! |
Hello everyone,
This pull request attempts to solve rust-lang/rust#62490.
I have based my notes on the discussion from #522
Hope this is helpful :-)