Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow assigning PRs to members of the project stable MIR #1119

Closed
wants to merge 1 commit into from

Conversation

celinval
Copy link
Contributor

These members were granted r+ permission here: #1110

However, trying to assign a PR to them will trigger a rustbot error. I think the problem is that we also need to add the team as repo maintainers.

These members were granted r+ permission here: rust-lang#1110

However, trying to assign a PR to them will trigger a rustbot error:

> Failed to set assignee to celinval: invalid assignee
>> Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.


I think the problem is that we also need to add the team as maintainers.
@ehuss
Copy link
Contributor

ehuss commented Nov 16, 2023

Hi! This isn't the correct file to edit to give permissions on the rust-lang/rust repo. This file controls access to the https://github.com/rust-lang/rust-forge/ repo, which controls the forge website.

To be assignable, they need to be given permissions on the rust-lang/rust repo, which unfortunately is not yet managed by this automated infrastructure. Someone in the infra team will need to manually add them. I suggest following up in the #t-infra stream on Zulip.

@celinval
Copy link
Contributor Author

Gotcha! Let me do that. Thanks

@celinval celinval closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants