Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a wg-prioritization/alerts Zulip user group #836

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

rylev
Copy link
Member

@rylev rylev commented Sep 9, 2022

This adds automatic syncing of the `wg-prioritization/alerts' Zulip user group with the membership of the wg-prioritization working group.

The user group is not currently very well synced with the working group. When this merges the following will happen:

These folks will join the user group: @camelid, @Dylan-DPC, @hkmatsumoto, @inquisitivecrystal, @lcnr, @pnkfelix, @TaKO8Ki.

The following folks will be removed (both of whom are not in the team repo, and so I don't know their GitHub handles): Xu Ran, Chris Dolby.

r? @apiraino @wesleywiser

@rylev rylev mentioned this pull request Sep 9, 2022
27 tasks
@lcnr
Copy link
Contributor

lcnr commented Sep 9, 2022

I do not want to be part of the alerts zulip group. We intentionally split @*WG-prioritization* and @*WG-prioritization/alerts* so that people can be part of WG-prioritization without getting pinged for new threads in the alerts channel.

@rylev
Copy link
Member Author

rylev commented Sep 9, 2022

This is good context. We can easily add your name to the excluded-people field which removes you from that Zulip group. I'll wait for others to chime in on if they'd like to be excluded before committing that.

@Dylan-DPC
Copy link
Member

Would like to be excluded from the alerts as well for the time being

@spastorino
Copy link
Member

@rylev I'd also want to be left out of @*WG-prioritization/alerts* or well maybe even better I should just be removed from the whole working group as I'm not doing anything since a while.

Anyway, in general, I'd say that we can just copy what we already have on Zulip. There's some people that belongs to the Zulip @*WG-prioritization* group and a subset of that people belongs to @*WG-prioritization/alerts*. That allows to ping the team for general discussion and to ping for alert on every single issue that ask for notifications.

In any case, cc @apiraino, it may be also good to also take some time and cleanup the list of members.

@apiraino
Copy link
Contributor

apiraino commented Sep 11, 2022

Why do we want to map the Zulip t-compiler/wg-prioritization/alerts group in the team repository? What happens when this Zulip group is mapped in this file?

As far as I know, t-compiler/wg-prioritization/alerts is just an opt-in subgroup to receive notifications about issues to be prioritized (the actual Zulip group is t-compiler/wg-prioritization).

Besides, @spastorino is right - we need to update the wg-prioritization roster to remove stale members (something I will take care of).

@rylev
Copy link
Member Author

rylev commented Sep 12, 2022

@apiraino we want to be able to control all zulip user groups from this repo (or at the very least some other well defined place). The current process of "just know that you have to ask someone with permissions" is not sustainable.

@apiraino
Copy link
Contributor

we want to be able to control all zulip user groups from this repo

oh ok, I just thought that t-compiler/wg-prioritization/alerts didn't need to be "managed" in that sense.

anyway, ok for me if this is useful. We will cleanup and add to the excluded list those wishing to not be part of it

Note: many Zulip members are in t-compiler/wg-prioritization/alerts but they don't want to receive notification (so - I think - they muted notifications in the Zulip settings). Unsure what happens in this regard when they will be added here and the sync tool will run :)

thanks @rylev

@camelid
Copy link
Member

camelid commented Sep 14, 2022

I would also like to be removed from the new wg-prioritization/alerts, though I would like to remain part of wg-prioritization.

@rylev
Copy link
Member Author

rylev commented Sep 29, 2022

@Mark-Simulacrum this should be ready to go. I've added more folks to the excluded list such that it should not actually change who is in the user group.

@rylev rylev force-pushed the wg-prioritization/alerts branch from 479bc92 to 74eed67 Compare September 29, 2022 12:49
@Mark-Simulacrum Mark-Simulacrum merged commit c12fc7c into rust-lang:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants