Fix cargo milestoning timeout. #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where not all cargo PRs were getting milestoned. The process of milestoning all the cargo PRs can take more than 10 seconds. This was causing the thread to get cancelled due to the webhook timeout. This fixes the problem by spawning a background task to handle the milestoning process.
|
just curious: do we know why adding a milestone takes long? By looking at #1751 I wonder if adding a milestone is more a "cronjob-like" task or it needs to be triggered manually on some other event. |
|
It needs to hit the |
Mark-Simulacrum
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where not all cargo PRs were getting milestoned.
The process of milestoning all the cargo PRs can take more than 10 seconds. This was causing the thread to get cancelled due to the webhook timeout.
This fixes the problem by spawning a background task to handle the milestoning process.