Improve rendered link handler with proper edit and sha-based link #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
reviewed
Oct 24, 2024
Urgau
force-pushed
the
rendered_link-improvements
branch
from
80a62fa to
b5f9af7
Compare
ehuss
reviewed
Oct 26, 2024
Urgau
force-pushed
the
rendered_link-improvements
branch
from
b5f9af7 to
8f211e0
Compare
ehuss
approved these changes
Oct 30, 2024
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
rendered_linkhandler to be more robust, in particular regarding closing/merging of a PR with a SHA-based url in those cases.Fixes #1803
r? @ehuss