Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #132

Merged
merged 2 commits into from
May 28, 2019
Merged

Update README #132

merged 2 commits into from
May 28, 2019

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented May 25, 2019

Updates the readme:

  • add links / badges to the UCGs book
  • updates some links (active discussion topic, etc.)
  • updates meeting times
  • tries to keep it brief

Rendered.

@gnzlbg gnzlbg force-pushed the readme_update branch 4 times, most recently from 79238a4 to 7e404bb Compare May 25, 2019 10:47
@gnzlbg gnzlbg closed this May 25, 2019
@gnzlbg gnzlbg reopened this May 25, 2019
@RalfJung
Copy link
Member

CI is not happy

1.07s$ cargo install mdbook
    Updating crates.io index
error: binary `mdbook` already exists in destination as part of `mdbook v0.2.3`
Add --force to overwrite
The command "cargo install mdbook" failed and exited with 101 during .

RalfJung
RalfJung approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the CI failure.

@gnzlbg gnzlbg merged commit 183e15f into rust-lang:master May 28, 2019
@gnzlbg
Copy link
Contributor Author

gnzlbg commented May 28, 2019

CI is green now, it appears that installing a package that's cached can fail.. I really hate that about cargo. If I write cargo install foo,foo is already installed, and the installed version is exactly the one that would have been installed (not older, etc.), then the command should just succeed, and not fail.

@RalfJung
Copy link
Member

Seems like you want rust-lang/cargo#6798?

@gnzlbg
Copy link
Contributor Author

gnzlbg commented May 28, 2019

Nice! That's great! It currently requires cargo +nightly install mdbook -Z install-upgrade, but might become the default behavior soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnzlbg @RalfJung