This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
Goto implementation command needs updating #368
Comments
Just changing the command at https://github.com/rust-lang-nursery/rls-vscode/blob/master/src/extension.ts#L214 works now. However, looking at the vscode and vscode-languageserver-node LSP client lib we're using, it should automatically populate the context menus (rather than us having to manually add the context menu item ourselves) - looking at it right now. |
Hopefully microsoft/vscode#54317 will be merged - this will bring standard VSCode Go to Implementation to the menu and we won't have to manually register the action anymore. Until then we should use a fallback, at least for the full nightly -> stable release cycle. |
Xanewok
pushed a commit
to Xanewok/rls-vscode
that referenced
this issue
Mar 27, 2019
… r=alexheretic Bump jsonrpc-core from 9.0.0 to 10.0.1 Bumps [jsonrpc-core](https://github.com/paritytech/jsonrpc) from 9.0.0 to 10.0.1. <details> <summary>Release notes</summary> *Sourced from [jsonrpc-core's releases](https://github.com/paritytech/jsonrpc/releases).* > ## JSON-RPC v10.0.1 > Fixes documentation links and authors. > > ``` > jsonrpc-core = "10.0.1" > jsonrpc-macros = "10.0.1" > jsonrpc-derive = "10.0.1" > jsonrpc-pubsub = "10.0.1" > jsonrpc-server-utils = "10.0.1" > jsonrpc-http-server = "10.0.1" > jsonrpc-ipc-server = "10.0.1" > jsonrpc-tcp-server = "10.0.1" > jsonrpc-ws-server = "10.0.1" > jsonrpc-stdio-server = "10.0.1" > jsonrpc-test = "10.0.1" > ``` > > ## JSON-RPC v10.0.0 > This is an exciting release, because it's the first time we release all parts of the suite to crates.io! So long github dependencies! > > Most notable changes: > 1. Deprecating `jsonrpc-macros` in favour of `jsonrpc-derive` (proc-macro based) > 2. Rewrting all crates to `edition = 2018` > > Other changes: > - Adding `Metadata` to unsubscribe methods (when they are called explicitly) > - Derive `Clone` for all `core` types > - Fix custom bounds on the types in `jsonrpc-macros` > - Fix charset case sensitivity for http server > > > Full list of changes: paritytech/jsonrpc@v9.0.0...v10.0.0 > > ``` > jsonrpc-core = "10.0.0" > jsonrpc-macros = "10.0.0" > jsonrpc-pubsub = "10.0.0" > jsonrpc-server-utils = "10.0.0" > jsonrpc-http-server = "10.0.0" > jsonrpc-ipc-server = "10.0.0" > jsonrpc-tcp-server = "10.0.0" > jsonrpc-ws-server = "10.0.0" > jsonrpc-stdio-server = "10.0.0" > jsonrpc-test = "10.0.0" > ``` </details> <details> <summary>Commits</summary> - [`8ffc7f3`](paritytech/jsonrpc@8ffc7f3) Add jsonrpc-derive details. ([rust-lang#372](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/372)) - [`2fe3bfc`](paritytech/jsonrpc@2fe3bfc) One way serialize for subscriber type ([rust-lang#371](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/371)) - [`37b62a3`](paritytech/jsonrpc@37b62a3) Migrate to edition 2018 ([rust-lang#368](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/368)) - [`5a7be5f`](paritytech/jsonrpc@5a7be5f) Bump version of stdio ([rust-lang#367](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/367)) - [`2b47a5c`](paritytech/jsonrpc@2b47a5c) Use parity-ws-rs from crates.io ([rust-lang#361](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/361)) - [`8160eb5`](paritytech/jsonrpc@8160eb5) ci: bring appveyor back ([rust-lang#364](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/364)) - [`80205d4`](paritytech/jsonrpc@80205d4) Support multiple trailing arguments ([rust-lang#365](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/365)) - [`ec5249e`](paritytech/jsonrpc@ec5249e) Use procedural macros ([rust-lang#340](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/340)) - [`789c74d`](paritytech/jsonrpc@789c74d) Derive Clone for all core types::* ([rust-lang#359](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/359)) - [`16ed9f5`](paritytech/jsonrpc@16ed9f5) Fix tokio deprecation warnings ([rust-lang#358](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/358)) - Additional commits viewable in [compare view](paritytech/jsonrpc@v9.0.0...v10.0.1) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=jsonrpc-core&package-manager=cargo&previous-version=9.0.0&new-version=10.0.1)](https://dependabot.com/compatibility-score.html?dependency-name=jsonrpc-core&package-manager=cargo&previous-version=9.0.0&new-version=10.0.1) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in the `.dependabot/config.yml` file in this repo: - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As of this in the rls repo the rls now uses the standard
textDocument/implementation
command instead ofrustDocument/implementations
. The menu item provided by this extension should be fixed to use the correct method (either via configuration or some other manner)The text was updated successfully, but these errors were encountered: