Remove unrecognized platform report button #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a steady stream of issues generated by this report button. None of the people who opened issues would be responsive and eloborate on the kind of platform they're using. Most of them had "Android" in their user agent, even though the issue template specifically said not to open an issue if one is using Android. At this point, it seems safe to assume the platform detection code works pretty well and getting rid of the report button is not a big loss.
senekor
commented
Oct 3, 2024
| <div id="platform-instructions-default" class="instructions dn"> | ||
| <div> | ||
| <p> | ||
| {{tools-rustup-manual-default}} | ||
| {{fluent "tools-rustup-manual-default"}} |
There was a problem hiding this comment.
I believe this "platform-instructions-default" element was never really displayed, "platform-instructions-unknown" was always the fallback. So this translation didn't even render correctly.
We could also hide the button on android. but yeah let's get rid of this. |
Manishearth
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a steady stream of issues generated by this report button.
None of the people who opened issues would be responsive and eloborate on the kind of platform they're using. Most of them had "Android" in their user agent, even though the issue template specifically said not to open an issue if one is using Android.
At this point, it seems safe to assume the platform detection code works pretty well and getting rid of the report button is not a big loss.