Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ndarray to version 0.13 #172

Merged
merged 3 commits into from
Oct 9, 2019
Merged

Update ndarray to version 0.13 #172

merged 3 commits into from
Oct 9, 2019

Conversation

stefan-k
Copy link
Contributor

@stefan-k stefan-k commented Oct 6, 2019

No description provided.

LukeMathWalker
LukeMathWalker approved these changes Oct 6, 2019
View reviewed changes
Copy link
Member

@LukeMathWalker LukeMathWalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time! @stefan-k

jturner314
jturner314 approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@jturner314 jturner314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I added a few minor suggestions.

src/krylov/householder.rs Outdated Show resolved Hide resolved
src/krylov/mgs.rs Show resolved Hide resolved
src/krylov/mgs.rs Show resolved Hide resolved
@stefan-k
Copy link
Contributor Author

stefan-k commented Oct 9, 2019

Thank you for the suggestions!

@stefan-k
Copy link
Contributor Author

stefan-k commented Oct 9, 2019

I probably should have tested the suggestions locally instead of simply accepting them on Github ;)

@jturner314
Copy link
Member

My bad. I'm sorry for the incorrect suggestions. I wasn't entirely sure that removing the &mut * would work, but I knew CI would catch any issues. :)

@jturner314 jturner314 merged commit bf5ab89 into rust-ndarray:master Oct 9, 2019
@jturner314
Copy link
Member

Thanks for this @stefan-k!

@stefan-k stefan-k deleted the ndarray_0.13 branch October 10, 2019 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeMathWalker LukeMathWalker LukeMathWalker approved these changes

@jturner314 jturner314 jturner314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefan-k @jturner314 @LukeMathWalker