unused qualifications #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, you're tough on your code -- that lint is default-allow! The change is fine, but can you also exercise the "deny" in a test? |
|
Ok, I'm going to add tests. |
|
Great, thanks, and I've extended this for bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 26, 2018
9: unused qualifications r=cuviper a=Pzixel
This code won't work on 0.1.43:
```rust
#![deny(trivial_numeric_casts)]
#![deny(unused_qualifications)]
extern crate num;
#[macro_use]
extern crate num_derive;
use num::ToPrimitive;
#[derive(ToPrimitive)]
pub enum SomeEnum {
A = 1
}
fn main() {
println!("{}", SomeEnum::A.to_i64().unwrap())
}
```
This is an attempt to fix it
Build succeeded |
|
Published! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code won't work on 0.1.43:
This is an attempt to fix it