Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change rustc-abi in custom targets to x86-softfloat #491

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented Feb 4, 2025

With the latest nightly, setting "+soft-float" in "features" is only allowed if "rustc-abi" is set to "x86-softfloat".

Fixes a nightly breakage introduced by rust-lang/rust#136146

With the latest nightly, setting "+soft-float" in "features" is only
allowed if "rustc-abi" is set to "x86-softfloat".
@Freax13 Freax13 requested a review from phil-opp February 4, 2025 05:53
@Freax13
Copy link
Member Author

Freax13 commented Feb 4, 2025

Given that 0.9.29 is more widely used than 0.11.9 (probably because of blog_os?), I think we should backport this fix.

Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@phil-opp phil-opp merged commit b6d3ef4 into main Feb 6, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants