Add async sink for sending packets #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raoulstrackx
approved these changes
Nov 20, 2024
| let mut guard = ready!(sink.inner.poll_write_ready_mut(cx))?; | ||
|
|
||
| if let Some(packet) = packet_storage.take() { | ||
| match guard.try_io( |
There was a problem hiding this comment.
Nitpick: this match is a bit hard to parse due to the closure. Consider create a separate variable for it.
|
@jethrogb Thanks for the PR! Could you please do the following so that I can merge this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an implementation of
futures::Sinkto be able to send packets asynchronously. (UNIX only - I'm not too familiar with Windows).The
SinkAPI is a bit difficult to understand. This implementation is modeled afterUnfoldandIntoSink.