Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasi: Update and Fix Travis failures #126

Merged
merged 2 commits into from
Jan 5, 2020
Merged

Conversation

josephlr
Copy link
Member

@josephlr josephlr commented Jan 2, 2020

It looks like Rust is now shipping a different version of the WASI toolchain. This toolchain now requires the corresponding runner to have wasi_snapshot_preview1 as part of its environment.

Updating the version of the wasi runner to 0.8 allows us to run the binaries created by newer Rust toolchains. See: bytecodealliance/wasi-rs#37

We also update the wasi version to 0.9 to get on a stable interface. This requires us to use unsafe again (as the current API does not have slice-based helpers anymore). The new API also gets ride of error_str, so we have to go though wasi::Error.

CC: @sunfishcode

Signed-off-by: Joe Richey [email protected]

@josephlr josephlr requested a review from newpavlov January 2, 2020 12:32
@sunfishcode
Copy link
Contributor

Could you provide more details? I'm able to build this crate and run all the tests with wasm32-wasi with both stable and nightly Rust.

@josephlr
Copy link
Member Author

josephlr commented Jan 3, 2020

Could you provide more details? I'm able to build this crate and run all the tests with wasm32-wasi with both stable and nightly Rust.

Sorry it's not building that's a problem, it's running the code. I keep getting a "Import module wasi_snapshot_preview1 was not found" even when using the never versions of wasi (like 0.9.0).

@josephlr
Copy link
Member Author

josephlr commented Jan 3, 2020

I keep getting a "Import module wasi_snapshot_preview1 was not found" even when using the never versions of wasi (like 0.9.0).

Looks like the issue was that the runner version (not the library version) which was causing issues. Let's see if this fixes things.

@josephlr josephlr changed the title wasi: Remove wasi presubmits wasi: Fix Travis Build failures Jan 3, 2020
@josephlr josephlr changed the title wasi: Fix Travis Build failures wasi: Fix Travis failures Jan 3, 2020
We are now no longer using an interface explictly marked "unstable".

Signed-off-by: Joe Richey <[email protected]>
@josephlr josephlr changed the title wasi: Fix Travis failures wasi: Update and Fix Travis failures Jan 3, 2020
@newpavlov newpavlov merged commit 48781cd into rust-random:master Jan 5, 2020
@josephlr josephlr deleted the wasi branch January 6, 2020 16:59
This was referenced Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants