Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Cargo.lock #595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Commit Cargo.lock #595

wants to merge 1 commit into from

Conversation

newpavlov
Copy link
Member

This should improve CI times a bit since it allows cargo to skip update of the crates.io index.

The main disadvantage is that we will need to manually update it from time to time and that we may not immediately notice bugs in upstream dependencies.

@newpavlov newpavlov requested a review from josephlr January 29, 2025 03:23
@josephlr
Copy link
Member

It seems really useful to immediately notice bugs in upstream dependencies, but the deterministic builds/tests is quite nice.

Would it be possible to have some automation which bumps the Cargo.lock when a new transitive dependency gets released? I probably wouldn't want to rely on us having to manually update the file every now and then.

This could also help us with minimal version stuff, where we could have a Cargo_minimal.lock which we use to make sure our crate works with our specified minimum versions. But that's probably best left for another time.

@josephlr
Copy link
Member

@newpavlov do you know if there's a way to have Cargo.lock included as part of what the Swatinem/rust-cache action handles? Then we could cache a previous build's lockfile and then only need to pull stuff from crates.io when there's an updated dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants