-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use wasi-core isntead of libc #64
Conversation
Sounds like you know much more about WASI interfaces than myself. The only thing I can say is that this adds another dependency — but if Since both the |
As we thought about it more, the name "WASI core" has caused confusion in some places, so I've now renamed the "wasi-core" crate to "wasi". I'd also request holding off on merging this for just a while longer while we let the module naming scheme within the crate settle in a little more. But beyond that, I am starting to see the role for this "wasi" crate emerge. It's a minimal and So yeah, I think this PR here is good, just update the crate name and give it a little more time while we settle any remaining organizational issues :-). |
Done! I will wait for your word then before merging this PR. (BTW maybe it's worth to release an empty
Well, I thought |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! When do we want to merge this?
@sunfishcode |
Sorry for being slow on my end; merging this sounds good to me. |
Small Cargo.toml nit that got missed in rust-random#64
IIUC
wasi-core
will be the main crate for exposing low-level WASI Core API in Rust. We could link to the function directly as with some other targets, but probably we shouldn't do it, as right now__wasi_random_get
is not considered stable. See: rust-lang/libc#1434