Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate benchmarks to criterion-cycles-per-byte #1039

Closed
vks opened this issue Sep 7, 2020 · 3 comments · Fixed by #1490
Closed

Migrate benchmarks to criterion-cycles-per-byte #1039

vks opened this issue Sep 7, 2020 · 3 comments · Fixed by #1490
Labels
E-help-wanted Participation: help wanted

Comments

@vks
Copy link
Collaborator

vks commented Sep 7, 2020

criterion-cycles-per-byte provides benchmarks with cycles per byte, which would be more appropriate for RNGs than bytes per second.
@newpavlov
Copy link
Member

Note that criterion is a quite sizable dependency, which will increase runtime of CI jobs. It could be worth to keep such benchmarks in a separate crate with its own workspace, e.g. as was done here.

@vks
Copy link
Collaborator Author

vks commented Apr 16, 2021

Note that criterion is a quite sizable dependency, which will increase runtime of CI jobs.

This should hopefully be fixed with the new Cargo resolver.

vks added a commit to vks/rand that referenced this issue Apr 25, 2021
@vks
rand_distr: Port benchmarks to Criterion
f308726 
- The benchmarks are now living in their own crate. Therefore, this does
  not add any dev-dependencies to rand_distr.
- Instead of bytes per seconds, we now measure cycles per byte.

Refs rust-random#1039.
@vks vks mentioned this issue Apr 25, 2021
Merged
vks added a commit to vks/rand that referenced this issue Apr 25, 2021
@vks
rand_distr: Port benchmarks to Criterion
d35f291 
- The benchmarks are now living in their own crate. Therefore, this does
  not add any dev-dependencies to rand_distr.
- Instead of bytes per seconds, we now measure cycles per byte.

Refs rust-random#1039.
vks added a commit to vks/rand that referenced this issue May 24, 2021
@vks
rand_distr: Port benchmarks to Criterion
a6623cc 
- The benchmarks are now living in their own crate. Therefore, this does
  not add any dev-dependencies to rand_distr.
- Instead of bytes per seconds, we now measure cycles per byte.

Refs rust-random#1039.
@vks
Copy link
Collaborator Author

vks commented May 25, 2021

This was started with #1116 for rand_distr, but the other crates still have to be ported.

@vks vks mentioned this issue Aug 24, 2021
Closed
@dhardy dhardy added the E-help-wanted Participation: help wanted label Jul 20, 2024
@dhardy dhardy mentioned this issue Aug 29, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-help-wanted Participation: help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate remaining benchmarks to Criterion dhardy/rand
3 participants
@vks @dhardy @newpavlov