Seq module doc #828
Merged
Seq module doc #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review please anyone? |
vks
reviewed
Jun 24, 2019
vks
reviewed
Jun 24, 2019
src/seq/mod.rs
Outdated
| /// println!("{}", str); | ||
| /// } | ||
| /// ``` | ||
| /// Output: |
There was a problem hiding this comment.
Maybe rather call this "Possible output".
vks
reviewed
Jun 24, 2019
src/seq/mod.rs
Outdated
| fn choose_mut<R>(&mut self, rng: &mut R) -> Option<&mut Self::Item> | ||
| where R: Rng + ?Sized; | ||
|
|
||
| /// Produces an iterator that chooses `amount` elements from the slice at | ||
| /// random without repeating any, and returns them in random order. | ||
| /// Chooses `amount` elements from the slice at random, without repeatition, |
There was a problem hiding this comment.
"repeatition" -> "repetition"
vks
approved these changes
Jun 24, 2019
|
Hey, sorry, I don't think I'd be an appropriate reviewer any more since I've paged most of this out of my head and don't really have time to read up on it again. |
Note: macro arg substitution does not appear to work within documentation. Since the methods are on the same page, these links are not important.
vks
reviewed
Jun 26, 2019
vks
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sicking would you be kind enough to review this?