Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better version of #961. This produces identical assembly as the version with the unsafe code, since LLVM is smart enough to optimize this into a single load. I've just disassembled the entire binary with
objdump
and compared outputs so that I don't end up looking at the wrong function like last time.Code used for testing:
I have also confirmed that this particular path is exercised by my test code by inserting
panic!()
in the function and observing that my test code does indeed panic.