Rename method fn value()
on NodeMut<…>
to value_mut()
, re-introducing the former as an immutable getter
#42
+51
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
NodeMut<'a T>
only exposes …… but not an equivalent immutable …
This PR renames the existing
name(…)
toname_mut(…)
and re-introducesname(…)
as immutable getter.(This is a breaking change.)
While one could assume that anyone using
NodeMut
will also have mutable access to it I stumbled on situations where this wasn't the case (e.g. due to wanting to abstract overNodeRef
/NodeMut
for mere reading) and the lack of a non-mutatingnode()
getter made the code rather cumbersome to deal with as a consequence.The same goes for the lack of
fn children(&self) -> Children<'a, T>
onNodeMut
for what it's worth.