Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement HasRawWindowHandle for RawWindowHandle #89

Closed
wants to merge 2 commits into from
Closed

Implement HasRawWindowHandle for RawWindowHandle #89

wants to merge 2 commits into from

Conversation

tasgon
Copy link

@tasgon tasgon commented Feb 17, 2022

Just a small QoL change

@maroider
Copy link
Member

maroider commented Feb 17, 2022 •
edited
Loading

Thanks for taking the time to submit a PR.

Unfortunately, though, this change is unsound, as RawWindowHandle can't keep the underlying window alive, as required by any impl of HasRawWindowHandle (see #35, #49, #71, and #73).

@maroider maroider closed this Feb 17, 2022
@tasgon tasgon deleted the raw_window_handle_impl branch February 19, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tasgon @maroider