Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve keyboard event handling #108

Closed
rigtorp opened this issue Jan 11, 2017 · 2 comments
Closed

Improve keyboard event handling #108

rigtorp opened this issue Jan 11, 2017 · 2 comments
Labels
S - api Design and usability S - enhancement Wouldn't this be the coolest?

Comments

@rigtorp
Copy link
Contributor

rigtorp commented Jan 11, 2017

Winit / Glutin is used by the Rust terminal emulator Alacritty (https://github.com/jwilm/alacritty). It requires some improvements to the keyboard event handling and is using a fork of glutin (https://github.com/jwilm/glutin) with these improvements (https://github.com/jwilm/glutin/commits/keyboard-mods).

Would you be interesting in merging these changes after they have been reworked for latest version of winit?
@rigtorp rigtorp mentioned this issue Jan 11, 2017
Closed
@tomaka tomaka added S - api Design and usability S - enhancement Wouldn't this be the coolest? labels Jan 11, 2017
@rigtorp rigtorp mentioned this issue Jan 17, 2017
Merged
jrmuizel pushed a commit to jrmuizel/winit that referenced this issue Mar 29, 2017
Auto merge of rust-windowing#108 - emilio:wayland-not-yet, r=larsberg…
01c528f 
…strom

linux: Disable Wayland backend because it's unusable for Servo.

r? @larsbergstrom or @glennw or @pcwalton

Funny how that comment was there but was completely ignored.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/108)
<!-- Reviewable:end -->
jrmuizel pushed a commit to jrmuizel/winit that referenced this issue Mar 29, 2017
Auto merge of rust-windowing#115 - mbrubeck:servo-no-wayland, r=glennw
3633564 
Remove wayland support and dependencies

Our glutin fork has diverged significantly from upstream, and it will take significant work to merge them, or to move to some new windowing API built on top of glutin, winit, or otherwise.

In the meantime we are building very old Wayland libraries but never using them (rust-windowing#108).  As a short-term patch to improve Servo build times by not building a bunch of unused dependencies, this patch just rips out the unused wayland support from our fork.  (This code is already gone from upstream glutin, moved into `winit` and using newer, rewritten wayland crates.)

r? @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/115)
<!-- Reviewable:end -->
@Ralith Ralith mentioned this issue Apr 22, 2017
Merged
@Ralith
Copy link
Contributor

Ralith commented May 31, 2017

This was fixed by #112 and #164, right? Can the issue be closed?

@jwilm
Copy link
Contributor

jwilm commented May 31, 2017

Yeah, this is fixed.

@jwilm jwilm closed this as completed May 31, 2017
madsmtm pushed a commit to madsmtm/winit that referenced this issue Jun 11, 2022
@amrbashir
feat: add is_menu_visible (rust-windowing#108)
308411c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S - api Design and usability S - enhancement Wouldn't this be the coolest?
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Ralith @rigtorp @tomaka @jwilm