Webmerge2 #1035
Merged
Webmerge2 #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything typechecks, but nothing is implemented
Update the internal APIs to match the new API changes
goddessfreya
added a commit
to goddessfreya/winit
that referenced
this pull request
Jul 10, 2019
* Create the type layout Everything typechecks, but nothing is implemented * Implemented a few easy methods * Create the outline of event input and handler calls * Add key and mouse event support that typechecks * Get to a state where a canvas is spawned * Refactor out the stdweb functionality into different modules * Rearchitect to allow API compliance * Rename modules * Implement request_redraw * Implement focus event * Fix warnings * Handle ControlFlow::Exit * Handle ControlFlow::Exit and dealing with events-in-events * Fix compile failures and add canvas positioning * Clean up and document the core of stdweb event handling * Only send the request-redraw on the next animation frame * Fix the request_animation_frame lifetimes * Add access to the canvas in the Window * Add support for mouse wheel * WIP * Implement Poll and WaitUntil in the stdweb backend * Indicate that I will be maintaing the stdweb backend * Start implementing web-sys backend * Port remaining modules to web_sys * Fix throwToEscapeEventLoop function * TEMPORARY: add testing example * Prevent callbacks from being destroyed too early * Replace JS snippet with throw_str * Fix some warnings * Clean up Cargo.toml after incorrect rebase * Fix a panic due to double-borrow * Remove unnecessary set-to-wait in example * Update how timeouts are cleared to avoid possible double-clearing * Draft `web` platform structure * Implement `web_sys::Canvas` event listeners * Remove `Canvas` when dropped * Implement `Canvas::request_redraw` * Implement keyboard and blur/focus events * Support `ReceivedCharacter` event * Avoid leaking implementation details in `Canvas` API * Implement `stdweb` backend for `web` platform * Use latest `stdweb` revision * Fix feature names * Fix `set_cursor_icon` * Fix mouse release/press events * Add `dyn` keyword where necessary * Improve feature names to enable web backends * Bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo fmthas been run on this branchCHANGELOG.mdif knowledge of this change could be valuable to users