Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device description leak #2758

Merged
merged 2 commits into from
May 8, 2023

Conversation

xiaopengli89
Copy link
Contributor

@xiaopengli89 xiaopengli89 commented Apr 4, 2023

deviceDescription should be called in autoreleasepool.

图片

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users

@xiaopengli89 xiaopengli89 requested a review from madsmtm as a code owner April 4, 2023 12:52
Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that works, thanks for the contribution!

@madsmtm madsmtm merged commit 92592ec into rust-windowing:master May 8, 2023
madsmtm added a commit that referenced this pull request May 8, 2023
kchibisov pushed a commit to kchibisov/winit that referenced this pull request May 13, 2023
* Fix device description leak

* Update CHANGELOG.md

---------

Co-authored-by: Xiaopeng Li <[email protected]>
kchibisov pushed a commit that referenced this pull request May 14, 2023
* Fix device description leak

* Update CHANGELOG.md

---------

Co-authored-by: Xiaopeng Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants