-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Web specific documentation for various APIs #2941
Merged
daxpedda
merged 2 commits into
rust-windowing:master
from
daxpedda:web-doc-resize-observer
Jul 10, 2023
Merged
Improve Web specific documentation for various APIs #2941
daxpedda
merged 2 commits into
rust-windowing:master
from
daxpedda:web-doc-resize-observer
Jul 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
reviewed
Jul 9, 2023
c0facbb
to
96f1a9d
Compare
(set_)inner_size
(set_)inner_size
and WindowEvent::Occluded
96f1a9d
to
c15eed1
Compare
(set_)inner_size
and WindowEvent::Occluded
kchibisov
requested changes
Jul 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than that should be fine.
c15eed1
to
4fe18a4
Compare
Done, merging blocked because of the requested change 🤣. |
4c75c17
to
366968d
Compare
kchibisov
approved these changes
Jul 10, 2023
Co-Authored-By: Kirill Chibisov <[email protected]>
366968d
to
0043647
Compare
kchibisov
added a commit
to kchibisov/winit
that referenced
this pull request
Aug 14, 2023
) Co-authored-by: Kirill Chibisov <[email protected]>
kchibisov
added a commit
that referenced
this pull request
Aug 15, 2023
Co-authored-by: Kirill Chibisov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just documenting some Web specific behavior to
Window::(set_)inner_size
.Cc #2859.