Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Web specific documentation for various APIs #2941

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

daxpedda
Copy link
Member

@daxpedda daxpedda commented Jul 9, 2023

Just documenting some Web specific behavior to Window::(set_)inner_size.

Cc #2859.

src/window.rs Outdated Show resolved Hide resolved
@daxpedda daxpedda force-pushed the web-doc-resize-observer branch 3 times, most recently from c0facbb to 96f1a9d Compare July 9, 2023 20:09
@daxpedda daxpedda changed the title Document Web specific behavior for (set_)inner_size Document Web specific behavior for (set_)inner_size and WindowEvent::Occluded Jul 9, 2023
@daxpedda daxpedda force-pushed the web-doc-resize-observer branch from 96f1a9d to c15eed1 Compare July 9, 2023 20:57
@daxpedda daxpedda changed the title Document Web specific behavior for (set_)inner_size and WindowEvent::Occluded Improve Web specific documentation for various APIs Jul 9, 2023
Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that should be fine.

src/event.rs Outdated Show resolved Hide resolved
src/event.rs Outdated Show resolved Hide resolved
@daxpedda daxpedda force-pushed the web-doc-resize-observer branch from c15eed1 to 4fe18a4 Compare July 9, 2023 23:40
@daxpedda daxpedda requested a review from kchibisov July 9, 2023 23:49
@daxpedda
Copy link
Member Author

daxpedda commented Jul 9, 2023

Done, merging blocked because of the requested change 🤣.

@daxpedda daxpedda mentioned this pull request Jul 8, 2023
25 tasks
@daxpedda daxpedda force-pushed the web-doc-resize-observer branch 2 times, most recently from 4c75c17 to 366968d Compare July 10, 2023 00:15
@daxpedda daxpedda force-pushed the web-doc-resize-observer branch from 366968d to 0043647 Compare July 10, 2023 10:29
@daxpedda daxpedda merged commit db8de03 into rust-windowing:master Jul 10, 2023
kchibisov added a commit to kchibisov/winit that referenced this pull request Aug 14, 2023
kchibisov added a commit that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants