Try XOpenIM with different locale modifiers

[hcpl]

Implements the solution suggested in #277 (comment).

[hcpl]

Please let me know if you think this needs to be handled more gracefully, like returning CreationError instead of panicking.

[francesca64]

Thanks for tackling this!

Do you think you could rebase my commit for making XIM optional into your branch? That way, the issue should be completely resolved.

[hcpl]

@francesca64 thanks for the commit! I can't build your branch yet though:

error[E0308]: mismatched types
   --> src/platform/linux/x11/mod.rs:453:79
    |
453 |                         let mut count = (self.display.xlib.Xutf8LookupString)(window_data.ic, xkev,
    |                                                                               ^^^^^^^^^^^^^^ expected *-ptr, found enum `std::option::Option`
    |
    = note: expected type `*mut x11_dl::xlib::_XIC`
               found type `std::option::Option<*mut x11_dl::xlib::_XIC>`
    = help: here are some functions which might fulfill your needs:
            - .unwrap()

error[E0308]: mismatched types
   --> src/platform/linux/x11/mod.rs:460:75
    |
460 |                             count = (self.display.xlib.Xutf8LookupString)(window_data.ic, xkev,
    |                                                                           ^^^^^^^^^^^^^^ expected *-ptr, found enum `std::option::Option`
    |
    = note: expected type `*mut x11_dl::xlib::_XIC`
               found type `std::option::Option<*mut x11_dl::xlib::_XIC>`
    = help: here are some functions which might fulfill your needs:
            - .unwrap()

error: aborting due to 2 previous errors

error: Could not compile `winit`.

Can you fix these first? I'll try to rebase when it'll be ok to do so.

[francesca64]

Oh, whoops. I picked that commit out of my libxkbcommon branch, where that section of code doesn't exist. Sorting that out would be more involved than what I'm able to commit to right now, but fortunately, after this PR, I assume it would be rather unusual for users not to be able to get a valid input method.

I'm going to go ahead and give you a proper review now; sorry about that.

[francesca64]

These strings must be null-terminated.

[francesca64]

After doing some research, I believe this call should be preceded by an empty XSetLocaleModifiers, as is done in alacritty. Otherwise, the user's XMODIFIERS environment variable is never used. This is also done in GLFW, GTK, and so on.

[francesca64]

I'm thinking this likely also warrants a CHANGELOG entry. Applications that currently call XSetLocaleModifiers on their own to use the value from XMODIFIERS (namely alacritty, but presumably others as well) no longer need to do that, and that change would be inobvious otherwise.

[francesca64]

For one final concern, this should really have a comment explaining its purpose. It would be hard for future contributors to figure out the meaning of these constants and why we're looping over them.

[jwilm]

Thanks @hcpl and @francesca64 for working on this feature. It looks like all of the issues in this thread have been addressed, and the latest review was an approval. Can it be merged?

[francesca64]

Sorry for the delay.