iOS Abstract Out the UIView type from winit #609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
if knowledge of this change could be valuable to usersThere are a lot of changes to iOS in this pull request.
UIApplication
setjmp
hacks now happen inWindow::new
. This allowsPlatformSpecificWindowBuilderAttributes
to customize the specificUIView
class.winit
no longer sets up aGLKView
. Putting responsibility on other libraries likeglutin
andvulkano-win
to specify the exactUIView
subclass.EventsLoop
now explicitly checks that it's created on the main thread. AFAICT this was required before, but it was just UB to create it anywhere else.Window
can ever be created.EventsLoop
cannot be polled until aWindow
has been created - in order for theCFRunLoopRunInMode
calls to work.I have been testing it with
glutin
. mtak-/glutin@1a3066fLet me know what needs to be changed/etc.