Introduce WindowBuilderExt::with_app_id for wayland #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2018
francesca64
reviewed
Nov 11, 2018
src/os/unix.rs
Outdated
| @@ -225,6 +225,13 @@ pub trait WindowBuilderExt { | |||
| fn with_resize_increments(self, increments: LogicalSize) -> WindowBuilder; | |||
| /// Build window with base size hint. Only implemented on X11. | |||
| fn with_base_size(self, base_size: LogicalSize) -> WindowBuilder; | |||
|
|
|||
| /// Build window with a given app-id. It should match the `.desktop` | |||
There was a problem hiding this comment.
Suggested change
| /// Build window with a given app-id. It should match the `.desktop` | |
| /// Build window with a given `app-id`. It should match the `.desktop` |
Should app-id be in backticks?
There was a problem hiding this comment.
Actually, it should probably just be "application ID"
francesca64
reviewed
Nov 11, 2018
src/os/unix.rs
Outdated
| /// Build window with a given app-id. It should match the `.desktop` | ||
| /// file distributed with your program. Only relevant on Wayland. | ||
| /// | ||
| /// For details about application id conventions, see the |
There was a problem hiding this comment.
Suggested change
| /// For details about application id conventions, see the | |
| /// For details about application ID conventions, see the |
To be more consistent with the stylization you used in the CHANGELOG
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed some time ago, and allows applications to specify an application id that the wayland compositor will use to find the matching
.desktopfile.CHANGELOG.mdif knowledge of this change could be valuable to users