Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement window transparency on macOS. #95

Merged
merged 1 commit into from
Dec 4, 2016
Merged

Implement window transparency on macOS. #95

merged 1 commit into from
Dec 4, 2016

Conversation

frewsxcv
Copy link
Contributor

Fixes #57.

@frewsxcv frewsxcv mentioned this pull request Nov 26, 2016
Closed
@frewsxcv
Copy link
Contributor Author

r? @mitchmindtree

cargo run --example transparent

@mitchmindtree
Copy link
Contributor

Looks good to me on OS X 10.10.5 👍

screen shot 2016-11-27 at 11 19 52 am

@tomaka
Copy link
Contributor

tomaka commented Nov 27, 2016

I'm hesitant to merge this because of the weird travis failure.

@frewsxcv
Copy link
Contributor Author

@tomaka Currently, all the changes in this PR are commented out and the fail still exists, FWIW.

@frewsxcv
Copy link
Contributor Author

I think that issue should be fixed by rust-lang/cargo#3333.

@mitchmindtree mitchmindtree mentioned this pull request Nov 28, 2016
Merged
@tomaka
Copy link
Contributor

tomaka commented Nov 30, 2016

You should probably remove your tmp commits.

@frewsxcv
Copy link
Contributor Author

tmp commits are removed, but fetching from crates.io is broken on the nightlies. So might have to wait another day or two.

@frewsxcv frewsxcv closed this Dec 4, 2016
@frewsxcv frewsxcv reopened this Dec 4, 2016
@frewsxcv
Copy link
Contributor Author

frewsxcv commented Dec 4, 2016

@tomaka nightly is building now.

@tomaka tomaka merged commit 3b93c7c into rust-windowing:master Dec 4, 2016
@frewsxcv frewsxcv deleted the transparent branch December 4, 2016 13:49
jrmuizel pushed a commit to jrmuizel/winit that referenced this pull request Mar 29, 2017
Auto merge of rust-windowing#95 - pcwalton:mac-rounded-opengl-surface…
6fa59a3 
…s, r=metajack

Use the private `CGSSetSurfaceShape` API to make the OpenGL view inside an undecorated window have rounded corners.

This allows us to disable transparency on the OpenGL surface, which is a
huge performance win on browser.html. It mirrors the way that Cocoa
internally makes OpenGL views inherit rounded corners.

Requires servo/core-graphics-rs#51.

r? @metajack
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/95)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frewsxcv @mitchmindtree @tomaka