refactor(ci): split general workflow into testing and linting #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
|
I was watching the repo to verify my tests were working and found this. You probably already know, but the mocked tests are failing because the installation lib nss_wrapper got booted during the split. |
PThorpe92
approved these changes
Jan 1, 2024
|
@PThorpe92 awesome, thanks for fixing this, you're the best ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the general CI workflow into linting and testing, and also adds specific paths for triggering the CI. This prevents unnecessary tests when only the README is changed for example.