Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Binary Compilation #261

Merged
merged 3 commits into from
Oct 19, 2019
Merged

Fix Binary Compilation #261

merged 3 commits into from
Oct 19, 2019

Conversation

scrogson
Copy link
Member

@scrogson scrogson commented Oct 19, 2019

This PR picks up from where #256 left off and adds some tests and tweaks the workspace configuration.

@evnu do the changes to the workspaces make sense?

Cargo.toml Show resolved Hide resolved
@evnu
Copy link
Member

evnu commented Oct 19, 2019

@scrogson I think you forgot to add the new crate? :)

@scrogson
Copy link
Member Author

I think you forgot to add the new crate? :)

I messed up the .gitignore

@scrogson scrogson force-pushed the fix_binary_handling branch 2 times, most recently from 18581d8 to 0d46335 Compare October 19, 2019 18:55
@evnu
Copy link
Member

evnu commented Oct 19, 2019

@scrogson were you able to reproduce the error from #256 with the new crate? I still don't understand completely how the error is triggered. We use [[bin]] as well in our crates, but did not see any such error yet.

@scrogson
Copy link
Member Author

scrogson commented Oct 19, 2019

were you able to reproduce the error from #256 with the new crate?

Yes. If you remove the first commit and try running this with the changes I've made, you should see the error.

We use [[bin]] as well in our crates, but did not see any such error yet.

It looks like if there is a [lib] section in the Cargo.toml the mix task skips the [[bin]] section entirely (might be nice to support both compiling libs and bins in the same crate). I noticed that when I added the [[bin]] section to the rustler_test crate, the binary was compiled, but, it wasn't moved into the priv/native dir.

@evnu
Copy link
Member

evnu commented Oct 19, 2019

This looks good then!

cristianberneanu and others added 2 commits October 19, 2019 14:44
A data section can contain multiple sets of values, instead of a single one.
@scrogson scrogson force-pushed the fix_binary_handling branch from 0d46335 to ca8d15f Compare October 19, 2019 19:45
@scrogson scrogson merged commit 4ed6e1f into master Oct 19, 2019
@filmor filmor deleted the fix_binary_handling branch June 6, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants