Abort compilation on macos if linker arguments are missing #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
If we do that, we might as well just force the correct arguments... |
You mean as in adding them to the |
evnu
force-pushed
the
macos-bail-if-missing-config
branch
2 times, most recently
from
df976d3 to
2697b62
Compare
evnu
force-pushed
the
macos-bail-if-missing-config
branch
from
2697b62 to
d5bd477
Compare
philss
approved these changes
Mar 17, 2022
|
I will merge this for now. @filmor and @rusterlium/core, I am open to reverting this if someone can think of a better strategy to handle linker arguments for macos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism to search through
.cargo/configfiles up from the crate to the workspace root in order to find target configuration for macos. If any such configuration is found, we assume that it contains the linker arguments required to make rustler work on macos.Fix #235.