Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

fix 65B model #66

Merged
merged 5 commits into from Mar 23, 2023
Merged

fix 65B model #66

merged 5 commits into from Mar 23, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 23, 2023

Import fixes for magic (#59 (comment)).

Fix 65B model error (#65).

A better fix for the memory allocation issue is probably possible, but this works without any impact on memory for any model (tested 7B: 4G, 13B: 5G, 30B: 20G, 65B: 39G).

@setzer22
Copy link
Collaborator

setzer22 commented Mar 23, 2023

Thanks for the PR! But I think this implements the same changes as #61? 😅

@ghost
Copy link
Author

ghost commented Mar 23, 2023

Thanks for the PR! But I think this implements the same changes as #61? sweat_smile

Not the buffer size change in 1d8b2c0.

@setzer22
Copy link
Collaborator

Right! It was easy to miss 😄 Now that #61 was just merged, would you mind updating your changes on top of this? Happy to merge the PR even if it's just the buffer size change

This reverts commit 733ef07.
@ghost
Copy link
Author

ghost commented Mar 23, 2023

@setzer22 should be done ^^

Copy link
Collaborator

@setzer22 setzer22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just added a little explanatory comment, we should be good to merge

@ghost ghost changed the title Import fixes for magic and fix 65B model fix 65B model Mar 23, 2023
@setzer22 setzer22 merged commit bf7bdbc into rustformers:main Mar 23, 2023
@setzer22 setzer22 mentioned this pull request Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant