ci: Replace max-parallel with an own job

To circumvent a race condition in `softprops/action-gh-release` where two draft releases are created in parallel and artifacts land in different draft releases

Signed-off-by: simonsan <[email protected]>

.github/workflows/release-cd.yml

@@ -26,8 +26,7 @@ jobs:
     name: Publishing ${{ matrix.job.target }}
     runs-on: ${{ matrix.job.os }}
     strategy:
-      fail-fast: false
-      max-parallel: 1
+      fail-fast: false # so we upload the artifacts even if one of the jobs fails
       matrix:
         rust: [stable]
         job:
@@ -97,6 +96,7 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
         with:
+
           fetch-depth: 0 # fetch all history so that git describe works
       - name: Create binary artifact
         uses: rustic-rs/create-binary-artifact-action@main # dev
@@ -119,6 +119,20 @@ jobs:
           use-project-version: true
           use-tag-version: true # IMPORTANT: this is being used to make sure the tag that is built is in the archive filename, so automation can download the correct version
 
+  create-release:
+    name: Creating release with artifacts
+    needs: publish
+    runs-on: ubuntu-latest
+    steps:
+      # Need to clone the repo again for the CHANGELOG.md
+      - name: Checkout repository
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
+        with:
+          fetch-depth: 0 # fetch all history so that git describe works
+
+      - name: Download all workflow run artifacts
+        uses: actions/download-artifact@6b208ae046db98c579e8a3aa621ab581ff575935 # v4
+
       - name: Creating Release
         uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844 # v1
         with:
@@ -127,6 +141,21 @@ jobs:
           body_path: ${{ github.workspace }}/CHANGELOG.md
           fail_on_unmatched_files: true
           files: |
-            ${{ env.BINARY_NAME }}-${{ env.PROJECT_VERSION }}-${{ matrix.job.target}}.tar.gz*
+            binary-*/${{ env.BINARY_NAME }}-*.tar.gz*
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+  result:
+    if: ${{ github.repository_owner == 'rustic-rs' }}
+    name: Result (Release CD)
+    runs-on: ubuntu-latest
+    needs:
+      - publish
+      - create-release
+    steps:
+      - name: Mark the job as successful
+        run: exit 0
+        if: success()
+      - name: Mark the job as unsuccessful
+        run: exit 1
+        if: "!success()"