Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(async): use is_async_compatible() to determine backend incompatibility and error out #1355

Merged
merged 6 commits into from
Nov 21, 2024
Merged

feat(async): use is_async_compatible() to determine backend incompatibility and error out #1355

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
db9b26e
fix: typo
nardoor Nov 17, 2024
6552020
fix(webdav): early fail when used with async incompatible repo
nardoor Nov 17, 2024
184a420
Merge branch 'main' into feature/async_incompatible
simonsan Nov 19, 2024
6a425fb
Merge branch 'main' into feature/async_incompatible
simonsan Nov 19, 2024
e99d3d0
Merge branch 'main' into feature/async_incompatible
simonsan Nov 20, 2024
7220029
Merge branch 'main' into feature/async_incompatible
simonsan Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/commands/webdav.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ impl WebDavCmd {
fn inner_run(&self, repo: CliIndexedRepo) -> Result<()> {
let config = RUSTIC_APP.config();

// webdav only works with async compatible repo
if !repo.is_async_compatible() {
return Err(anyhow!("Webdav is currently incompatible with the backend you are using. See https://github.com/rustic-rs/rustic/issues/1181 for more details."));
}

let path_template = config
.webdav
.path_template
Expand Down