rustls 0.23.22, opt-in prefer-post-quantum feature flag #520
+125
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
cpu
commented
Dec 29, 2024
cpu
force-pushed
the
cpu-rustls-pq
branch
2 times, most recently
from
094f722 to
a4d06a2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Notably this brings in support for post-quantum-secure key exchange using X25519MLKEM768 with the `aws-lc-rs` crypto provider. Support is enabled by default, but at a low negotiation priority. A subsequent commit will expose the feature required to make it the most preferred KX alg. See the upstream release notes for more information: https://github.com/rustls/rustls/releases/tag/v%2F0.23.22
cpu
changed the title
This should be ready for review now. The general approach has changed a little bit from the first draft based on what landed upstream in 0.23.22. This side is simpler now, so that's nice 🌠 I've updated the PR desc accordingly. |
ctz
approved these changes
Feb 5, 2025
When explicitly activated (it is not a default) this feature flag activates the matching upstream `rustls/prefer-post-quantum` feature flag, making the `aws-lc-rs` crypto provider prefer `X25519MLKEM768`. CI coverage for this build configuration is added to `test.yaml`, and a new daily test targetting the cloudflare PQ demo server is added to `daily-tests.yml`.
|
Since this ended up not requiring any code changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustls 0.23.20 -> 0.23.22
Notably this brings in support for post-quantum-secure key exchange using X25519MLKEM768 with the
aws-lc-rscrypto provider. Support is enabled by default, but at a low negotiation priority. A subsequent commit will expose the feature required to make it the most preferred KX alg.See the upstream release notes for more information:
add prefer-post-quantum feature flag
When explicitly activated (it is not a default) this feature flag activates the matching upstream
rustls/prefer-post-quantumfeature flag, making theaws-lc-rscrypto provider preferX25519MLKEM768.Since the default provider is augmented with
prefer-post-quantumthe existingclient.candserver.cexamples require no changes to benefit from the-DPREER_POST_QUANTUM=onCMake option. CI is updated to test a preferred post-QC secure key exchange usingclient.candpq.cloudflareresearch.com, checking that the output reports the correct KX on Windows/MacOS/Linux. This is done in the daily tests job since it relies on an external host.Here's an exemplar run from a manual invocation on this branch.
Resolves #507