Improve fuzzing coverage and improve processed data tracking #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
==========================================
- Coverage 94.64% 94.64% -0.01%
==========================================
Files 102 102
Lines 23974 23973 -1
==========================================
- Hits 22690 22689 -1
Misses 1284 1284 ☔ View full report in Codecov by Sentry. |
|
(Already pushed up https://github.com/rustls/rustls-fuzzing-corpora earlier this week.) |
Ah, sweet, thanks. |
ctz
force-pushed
the
jbp-improve-fuzzing-coverage
branch
3 times, most recently
from
29bcab3 to
61a7eff
Compare
ctz
changed the title
Split the corpus files, so there is one for each API at each protocol version.
`HandshakeDeframer` already knows where (if any) the in-place reconstruction of handshake messages is taking place. So have this be the single place where a `BufferProgress` is originated.
This defends the fix for bug 2159.
ctz
force-pushed
the
jbp-improve-fuzzing-coverage
branch
from
61a7eff to
2c893f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started as improving fuzzing, but adding working fuzzing of the unbuffered API involved redoing the fix to #2227, and that fixed #2159 at the same time.
The first commit can reach #2227 quite quickly, if cherry picked before that fix.
I will also reinstate the larger corpus repo once this is done.
fixes #2159