-
Notifications
You must be signed in to change notification settings - Fork 377
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add advisory for rustc_serialize (#1140)
- Loading branch information
Showing
1 changed file
with
28 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
```toml | ||
[advisory] | ||
id = "RUSTSEC-0000-0000" | ||
package = "rustc-serialize" | ||
date = "2022-01-01" | ||
categories = ["denial-of-service"] | ||
keywords = ["stack overflow"] | ||
|
||
[versions] | ||
patched = [] | ||
|
||
[affected] | ||
functions = { "rustc_serialize::json::Json::from_str" = ["*"] } | ||
``` | ||
|
||
# Stack overflow in rustc_serialize when parsing deeply nested JSON | ||
|
||
When parsing JSON using `json::Json::from_str`, there is no limit to the depth of the stack, therefore deeply nested objects can cause a stack overflow, which aborts the process. | ||
|
||
Example code that triggers the vulnerability is | ||
|
||
```rust | ||
fn main() { | ||
let _ = rustc_serialize::json::Json::from_str(&"[0,[".repeat(10000)); | ||
} | ||
``` | ||
|
||
[serde](https://crates.io/crates/serde) is recommended as a replacement to rustc_serialize. |