No dwarf #51
Merged
No dwarf #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tting This skips checking all of our items for whether they have names or not (which they won't if we aren't configured to emit names, but we don't need to do that big traversal in this case).
src/module/mod.rs
Outdated
| @@ -256,9 +256,17 @@ impl Module { | |||
| self.funcs.emit(&mut cx); | |||
| self.data.emit(&mut cx); | |||
|
|
|||
| emit_name_section(&mut cx); | |||
| if self.config.generate_names { | |||
There was a problem hiding this comment.
Oh so the generate_names here was intended for debugging passes in walrus itself, so a lot of debug information is tied to this currently. I think we may want a separate flag (on by default whereas the generate_names flag is off by default) to emit the name section?
| self.producers.emit(&mut cx); | ||
| for section in self.custom.iter() { | ||
| if !self.config.generate_dwarf && section.name.starts_with(".debug") { |
There was a problem hiding this comment.
I wonder if this should also be skipped when parsing to avoid keeping the dwarf sections in memory?
alexcrichton
approved these changes
Feb 14, 2019
…ems` Since this is not about generating the name section or not, but whether we give names like "f0" to anonymous functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.