web-sys: Unable to add body to a Request

[Bobo1239]

I'm trying to create a Request with a body but I can't figure out how (or it isn't possible yet). Neither Request nor RequestInit offer a way to add a body. Ultimately I'd like to do something like this.

[fitzgen]

RequestInit has a body member:

dictionary RequestInit {
  // ...
  BodyInit? body;
  // ...
};

and BodyInit is defined as

typedef (Blob or BufferSource or FormData or URLSearchParams or USVString) BodyInit;

I wonder if we support that kind of union yet... time to dig into the logs.

[afdw]

No, it is not yet supported. Only non-nullable unions with only interfaces in them are supported in dictionaries.

[fitzgen]

@afdw can you point me to where we identify and skip these members right now? I think we need better logging

[afdw]

wasm-bindgen/crates/webidl/src/idl_type.rs

Lines 508 to 528 in 4e86ecd

	IdlType::Union(idl_types) => {
	// Handles union types in all places except operation argument types.
	// Currently treats them as object type, if possible.
	// TODO: add better support for union types here?
	// Approaches for it:
	// 1. Use strategy of finding the nearest common subclass (finding the best type
	// that is suitable for all values of this union)
	// 2. Generate enum with payload in Rust for each union type
	if idl_types
	.iter()
	.all(|idl_type|
	match idl_type {
	IdlType::Interface(..) => true,
	_ => false,
	}
	) {
	IdlType::Object.to_syn_type(pos)
	} else {
	None
	}
	},

[fitzgen]

Thanks!

[fitzgen]

I think it is OK to fall back to JsValue for nullable unions