web-sys's API around Window seems to be wrong #834
Comments
|
And it seems to me that to reasonably implement |
|
Gah -- we hadn't considered multiple +cc @alexcrichton |
|
Makes sense to me, I'll work on reverting #761 |
alexcrichton
added a commit
to alexcrichton/wasm-bindgen
that referenced
this issue
Sep 17, 2018
This is intended to address rustwasm#834 where we don't actually want methods scoped like this! Instead we'll provide one unique accessor for the `window` object itself.
alexcrichton
added a commit
to alexcrichton/wasm-bindgen
that referenced
this issue
Sep 18, 2018
This is intended to address rustwasm#834 where we don't actually want methods scoped like this! Instead we'll provide one unique accessor for the `window` object itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, web-sys provides a Window type and use static functions to access objects and functions in the current global.
This seems to be conceptually wrong. Window is an object, and there can be multiple independent Window around, so the current global is just one Window object.
I suggest it provide a top level function
window()which returns aOption<Window>instead (Optionbecause the code may run in worker / worklet global wherewindowisn't available).The text was updated successfully, but these errors were encountered: