Add attribute for custom path to wasm_bindgen
#3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
commented
Mar 17, 2023
Comment on lines
+46
to
+47
| wasm_bindgen: syn::parse_quote! { wasm_bindgen }, | ||
| wasm_bindgen_futures: syn::parse_quote! { wasm_bindgen_futures }, |
There was a problem hiding this comment.
This should have been ::wasm_bindgen and ::wasm_bindgen_futures for added proc-macro hygiene. Unfortunately that would be a breaking change.
There was a problem hiding this comment.
Mentioning it here for reference: we can make that change alongside #3372.
daxpedda
commented
Mar 17, 2023
Comment on lines
+159
to
+161
| wasm_bindgen: wasm_bindgen.unwrap_or_else(|| syn::parse_quote! { wasm_bindgen }), | ||
| wasm_bindgen_futures: wasm_bindgen_futures | ||
| .unwrap_or_else(|| syn::parse_quote! { wasm_bindgen_futures }), |
daxpedda
force-pushed
the
custom-path
branch
4 times, most recently
from
ce4ac9a to
76ca9f6
Compare
|
The latest |
ranile
approved these changes
Apr 11, 2023
Comment on lines
+46
to
+47
| wasm_bindgen: syn::parse_quote! { wasm_bindgen }, | ||
| wasm_bindgen_futures: syn::parse_quote! { wasm_bindgen_futures }, |
There was a problem hiding this comment.
Mentioning it here for reference: we can make that change alongside #3372.
| @@ -0,0 +1,43 @@ | |||
| extern crate wasm_bindgen as extern_test; | |||
There was a problem hiding this comment.
Ideally we should have a separate crate which renames wasm-bindgen in Cargo.toml but this should also suffice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new attributes:
wasm_bindgenandwasm_bindgen_futures, which allow to specify the path to both crates if they were renamed or re-exported from a different crate.This is analogous to Tokio, Serde or Pollster.