feat: add possibility to select a version for geckodriver to install #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arn-the-long-beard
changed the title
arn-the-long-beard
changed the title
MartinKavik
reviewed
Aug 9, 2020
src/test/webdriver/geckodriver.rs
Outdated
| let geckodriver_version = if target::WINDOWS { | ||
| log::info!( | ||
| "[geckodriver] Windows detected, holding geckodriver version to {}", | ||
| DEFAULT_WINDOWS_GECKODRIVER_VERSION | ||
| ); | ||
| DEFAULT_WINDOWS_GECKODRIVER_VERSION.to_owned() | ||
| } else if specified_geckodriver_version.is_ok() { |
There was a problem hiding this comment.
I would probably switch conditions if target::WINDOWS and if specified_geckodriver_version.is_ok() otherwise you wouldn't be able to specify the version on Windows.
There was a problem hiding this comment.
I wasn't sure because it seems the version for windows had to be 0.24.0.
… users can also select a version
MartinKavik
approved these changes
Aug 9, 2020
|
Hello guys, what should we do with this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys !!!
I checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting-> It did touched some other lines in the code that I did'nt touch :P
-> Running tests in headless mode for Firefox is failing with 500 code response but ok in web browser wasm-bindgen#2261 (comment)
Since the 27th of July there is a bug with headless mode for firefox on the latest geckodriver.
So, it could be nice to give us the opportunity to choose which version we want to install.
What we need to do :
geckodriverThis PR is draft, because I am not pro and maybe we can find a good solution together 😄
My first reflex is that we could use environment variable to do that, but maybe we can use
featureor something else.Thank you for your inputs.
By the way, the test I made is failing, and even with debugging in my IDE, I do not know where it is failing. Can somebody give me a hand on this ?
✨ Thank you for your inputs ✨
Issue : rustwasm/wasm-bindgen#2261 (comment)