-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest shiny stuff #92
Conversation
* readable-stream@3 * remove sauce test garbage * new tape & bl for testing * no Buffer constructor in test * travis update (is it connected?) * remove license year
Are you sure copyright years are optional in copyright notices? |
yeah, sure enough that I'm just going to do it |
Is it possible to update to 3.0.2? Was going to open a PR to do so to fix an NPM bug seen here but if you are already updating this may save me some work! |
Can we make it depend on either 2 or 3? E.g. - "readable-stream": "^3.0.1",
+ "readable-stream": "2 || 3", I use |
@rvagg Need help with anything? I'd love to see this merged. If a prerelease is made for this, I can help test. |
While we are at it, can we replace xtend for Object.assign? |
Is there anything blocking this PR from being merged? I'm in the opposite situation now than I was in September... all my other dependencies have been updated to use |
If you want Included This is a semver-patch bump, I can't find a reason for it to be semver-minor, crossing fingers that I'm not overlooking anything that might break anyone's stuff in prod. Really the only change to
|
Is Node 6 now a requirement? If so, that's one reason it should be 3.0.0. (Haven't tested this.) I know split2 went to 3.0.0 for |
@dwieeb I don't think Node 6 is a strict requirement, because in the package.json he lists |
@wmhilton But this module is now using |
Note: as per #95, I've rolled this back and went with a readable-stream@2 pin for 2.0.5 and am maintaining the diff in a |
And suddenly all the people using node 0.10 and npm 1.x came out of the woodwork. That's seriously scary LoL. |
Nothing revolutionary