Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XLIFF: Create New Target File(s) - Typing in language tag manually #26

Closed
pmatsconsulting opened this issue Oct 18, 2019 · 6 comments
Closed
Labels
enhancement New feature or request shipped Issue is available in the public release.

Comments

@pmatsconsulting
Copy link

Configuration :

  • Multi-root workspaces
    Symptoms :
  • No error, no file generated
@rvanbekkum
Copy link
Owner

Could you tell me when the command does not work for you?
Just tested this in a multi-root workspace I set up earlier, but I don't run into any issues.

@rvanbekkum rvanbekkum added the input-needed Extra attention is needed label Oct 19, 2019
@pmatsconsulting
Copy link
Author

pmatsconsulting commented Oct 19, 2019

Was user experience fault from my part (rapid keyboad maniac!). Was typing from keyboard the target language and Enter without first, moving to the list, then checking the checkbox, and finally Enter...
Could be fine to autovalidate the target language if unique.

@rvanbekkum
Copy link
Owner

I see. I will check if I can change the command so that you can also just type in the target language tag without needing to select one (or more) from the pre-defined list.

@rvanbekkum rvanbekkum changed the title XLIFF: Create New Target File(s) doesn't work XLIFF: Create New Target File(s) - Typing in language tag manually Oct 19, 2019
@rvanbekkum rvanbekkum added enhancement New feature or request and removed input-needed Extra attention is needed labels Oct 19, 2019
@rvanbekkum
Copy link
Owner

rvanbekkum commented Oct 19, 2019

It appears that there is a limitation when the showQuickPick function from the VSCode API is used with canPickMany=true: pressing the Enter key will not select the active item, but instead close the menu. With canPickMany=false, pressing the Enter key does select the active item.

@pmoison Would something like this work for you?

  • I will change the command so that by default you will only get to select a single target language.
  • Accordingly, I will add two new options:
    • Select multiple... (will let you select multiple target languages from a list)
    • Enter custom... (will allow you to enter a custom tag, e.g., if it is not in the list)

image

Demo:

new-files

If you have some ideas/suggestions, please feel free to share!

@pmatsconsulting
Copy link
Author

That sounds great !

@rvanbekkum
Copy link
Owner

This change is shipped in version 0.3.1.

@rvanbekkum rvanbekkum added the shipped Issue is available in the public release. label Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shipped Issue is available in the public release.
Projects
None yet
Development

No branches or pull requests

2 participants