feat: add ability to define empty tag format #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a new setting called `useSelfClosingTags` which allow to define how empty tag must be write while generating new XLIFF synchronized files. its default value is `true` meaning empty tag will use self closing format (<note/>) - as it was the case prior this change. when set to `false`, empty tag will be write using opening and closing format (<note></note>). references : - oozcitak/xmlbuilder-js#65 - https://github.com/oozcitak/xmlbuilder-js/wiki#converting-to-string Closes rvanbekkum#97
|
Thank you for the PR. I have already checked the contents and it looks good. I will probably merge/release it next weekend (after Directions EMEA in Hamburg). |
|
Hello there, just a small bump about this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a new setting called
useSelfClosingTagswhich allow to define how empty tag must be write while generating new XLIFF synchronized files.its default value is
truemeaning empty tag will use self closing format (<note/>) - as it was the case prior this change.when set to
false, empty tag will be write using opening and closing format (<note></note>).as an example, AL Compiler is using the opening and closing format instead the self-closing one.
using this extension current version with AL project is then generating excessive git diff for small changes since all empty tags are updated to the self-closing format.
references :
Closes #97