Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update project settings" #3

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Revert "Update project settings" #3

merged 1 commit into from
Feb 13, 2018

Conversation

funkyboy
Copy link
Contributor

This reverts commit e9f7b14.

So that I can use Xcode 8.3 and Cocoapods 0.37.2 to update the pod. This lints correctly.

msgpack-objective-C> pod lib lint
 -> msgpack (0.2.0)

msgpack passed validation.
msgpack-objective-C>

@funkyboy
Copy link
Contributor Author

@rvi ready for your review. As soon as you merge into master I'll push the new pod to trunk. Ok?

@rvi
Copy link
Owner

rvi commented Feb 13, 2018

Sure, go for it! 🚀

@rvi rvi merged commit 9e204dd into rvi:master Feb 13, 2018
@funkyboy
Copy link
Contributor Author

Oops I forgot.
After merging you are gonna need to:

git pull
git tag '0.2.0'
git push --tags

@funkyboy
Copy link
Contributor Author

@rvi See above :)

@rvi
Copy link
Owner

rvi commented Feb 13, 2018

@funkyboy Done. You might have to delete your local tag 0.2.0 (created 2 days ago) when I tried to submit your changes. I just deleted it and recreated because was never submitted to trunk.

@funkyboy
Copy link
Contributor Author

@rvi I fetched changes from my trunk. Don't know if the tag was lost there. Thanks anyway.
Now shivering about this:

msgpack-objective-C> pod trunk push msgpack.podspec 
Updating spec repo `master`
[!] The `master` repo requires CocoaPods 1.0.0 -  (currently using 0.37.2)
Update CocoaPods, or checkout the appropriate tag in the repo.
msgpack-objective-C>

@funkyboy
Copy link
Contributor Author

@rvi @ricardopereira and of course when I update to 1.0.0 it doesn't find the ☔️
😠

msgpack-objective-C> pod lib lint

 -> msgpack (0.2.0)
    - ERROR | [iOS] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - ERROR | xcodebuild:  /Users/cesare/Library/Developer/Xcode/DerivedData/App-apwmvkwggxjmvvbfofrypeiwdyfe/Build/Products/Release-iphonesimulator/msgpack/msgpack.framework/Modules/module.modulemap:3:19: error: umbrella header 'msgpack-umbrella2.h' not found
    - NOTE  | xcodebuild:  /var/folders/r3/yyh_7qtd7rzb7fdpdtvkcxmh0000gn/T/CocoaPods/Lint/App/main.m:3:9: fatal error: could not build module 'msgpack'

[!] msgpack did not pass validation, due to 2 errors.
You can use the `--no-clean` option to inspect any issue.
msgpack-objective-C> 

This is 🍌 🍌 🍌 🍌

@rvi
Copy link
Owner

rvi commented Feb 13, 2018

Oh man

@rvi
Copy link
Owner

rvi commented Feb 13, 2018

Maybe it's time to submit a cocoapods issue? Or try to do the pod from scratch...

I remember I had to create a custom modulemap, otherwise, it wouldn't compile, mainly because of the C code embedded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants